0.0.228 (#411)

* fix: numpr reader

* fix

CHANGELOG.md

@@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## docx-wasm@0.0.228 (18. January, 2022)
+
+- Fixed a bug, numPr reader panic when id is none.
+
 ## docx-wasm@0.0.226, 0.0.227 (17. January, 2022)
 
 - Add `paragraphPropertyChange` api for JS.

docx-core/examples/reader.rs

@@ -4,7 +4,7 @@ use std::fs::File;
 use std::io::{Read, Write};
 
 pub fn main() {
-    let mut file = File::open("./ppr_del.docx").unwrap();
+    let mut file = File::open("./table-indent.docx").unwrap();
     let mut buf = vec![];
     file.read_to_end(&mut buf).unwrap();
 

docx-core/src/reader/numbering_property.rs

@@ -39,11 +39,12 @@ impl ElementReader for NumberingProperty {
                             return Ok(NumberingProperty::new()
                                 .id(NumberingId::new(id.expect("should id exists"))));
                         }
-                        let np = NumberingProperty::new().add_num(
+                        if let Some(id) = id {
-                            NumberingId::new(id.unwrap()),
+                            let np = NumberingProperty::new()
-                            IndentLevel::new(level.unwrap()),
+                                .add_num(NumberingId::new(id), IndentLevel::new(level.unwrap()));
-                        );
+                            return Ok(np);
-                        return Ok(np);
+                        }
+                        return Ok(NumberingProperty::new());
                     }
                 }
                 Err(_) => return Err(ReaderError::XMLReadError),

docx-wasm/package.json

@@ -1,6 +1,6 @@
 {
   "name": "docx-wasm",
-  "version": "0.0.227",
+  "version": "0.0.228",
   "main": "dist/node/index.js",
   "browser": "dist/web/index.js",
   "author": "bokuweb <bokuweb12@gmail.com>",

docx-wasm/test/index.test.js

@@ -106,6 +106,12 @@ describe("reader", () => {
     const json = w.readDocx(buffer);
     expect(json).toMatchSnapshot();
   });
+
+  test("should read table indent docx", () => {
+    const buffer = readFileSync("../fixtures/table_indent/table_indent.docx");
+    const json = w.readDocx(buffer);
+    expect(json).toMatchSnapshot();
+  });
 });
 
 describe("writer", () => {